Skip to content

Conversation

@bretep
Copy link
Contributor

@bretep bretep commented Apr 23, 2019

Fixes issue #505

@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 72.319%

Totals Coverage Status
Change from base Build 94: 0.04%
Covered Lines: 1126
Relevant Lines: 1557

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 72.319%

Totals Coverage Status
Change from base Build 94: 0.04%
Covered Lines: 1126
Relevant Lines: 1557

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 72.319%

Totals Coverage Status
Change from base Build 94: 0.04%
Covered Lines: 1126
Relevant Lines: 1557

💛 - Coveralls

@bretep
Copy link
Contributor Author

bretep commented Apr 23, 2019

The failure is unrelated to this commit and fails only for go1.8

@bretep
Copy link
Contributor Author

bretep commented Apr 25, 2019

@hmgle are you able to merge this?

@bretep
Copy link
Contributor Author

bretep commented Apr 25, 2019

I've been using this patch for the past 20 or so days. It's been working as expected. Thanks @hmgle

@hmgle
Copy link
Contributor

hmgle commented Apr 25, 2019

@jmoiron Could you please review and handle this pr? Thanks.

@bretep
Copy link
Contributor Author

bretep commented Apr 26, 2019

Thanks @hmgle for pingin @jmoiron

@jmoiron Hopefully we can get this committed soon so that I don't have to maintain a fork. :) Please let me know if I need to take any additional steps to get this PR accepted.

@jmoiron
Copy link
Owner

jmoiron commented Apr 26, 2019

The 1.8 failure is due to the mysql driver dropping support for 1.8; I believe my backwards compatability guarantee also drops 1.8 so I'll remove it from the testing matrix instead of trying to fix it.

Additionally, since there has been no tagged release yet for this feature (I want to get more time to live with it), I don't mind removing an exported identifier... in fact, I prefer it, it wasn't necessary to export in the first place.

@jmoiron jmoiron merged commit 1ae93ed into jmoiron:master Apr 26, 2019
@bretep
Copy link
Contributor Author

bretep commented Apr 26, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants