You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jmoiron Hopefully we can get this committed soon so that I don't have to maintain a fork. :) Please let me know if I need to take any additional steps to get this PR accepted.
The 1.8 failure is due to the mysql driver dropping support for 1.8; I believe my backwards compatability guarantee also drops 1.8 so I'll remove it from the testing matrix instead of trying to fix it.
Additionally, since there has been no tagged release yet for this feature (I want to get more time to live with it), I don't mind removing an exported identifier... in fact, I prefer it, it wasn't necessary to export in the first place.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #505