Separate Configure from Start #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for scenarios where you want to further explore/configure the tools from their extracted locations before actually starting them. Fixes joelverhagen#70.
kzu
added a commit
to devlooped/dotnet-tor
that referenced
this pull request
May 19, 2021
This allows manually editing (if needed) the torrc file if advanced tweaks are needed that aren't exposed in the tool as options. Forked TorSharp until joelverhagen/TorSharp#72 and joelverhagen/TorSharp#73 are merged/shipped.
|
Love it! Definitely seems cleaner and better for a library behavior. I want to get this in 😃. If you can share, what's the motivation for this change? Do you have a VM/image "prep" step that is decoupled in time from the execution? |
kzu
added a commit
to devlooped/dotnet-tor
that referenced
this pull request
Aug 15, 2021
All our required PRs have been merged: - joelverhagen/TorSharp#79 - joelverhagen/TorSharp#78 - joelverhagen/TorSharp#77 - joelverhagen/TorSharp#72 So we don't need the fork anymore :)
kzu
added a commit
to devlooped/dotnet-tor
that referenced
this pull request
Aug 15, 2021
All our required PRs have been merged: - joelverhagen/TorSharp#79 - joelverhagen/TorSharp#78 - joelverhagen/TorSharp#77 - joelverhagen/TorSharp#72 So we don't need the fork anymore :) Fixes #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for scenarios where you want to further explore/configure the
tools from their extracted locations before actually starting them.
Fixes #70.