Dependency conflict in latest Discourse upgrade

[Justinzobel]

discourse-ldap-auth/plugin.rb

Line 11 in edcf069

gem 'omniauth-ldap', '1.0.5'

Gem::ConflictError: Unable to activate omniauth-ldap-1.0.5, because omniauth-2.1.2 conflicts with omniauth (~> 1.0) (Gem::ConflictError)

[jonmbake]

We likely have to bump the version. Feel free to open a PR.

[Justinzobel]

We likely have to bump the version. Feel free to open a PR.

I would, but I don't know anything about ruby or which versions are compatible :)

[tormodvolden]

I tried bumping it to
gem 'omniauth-ldap', '2.0.0' (there is no intermediate tag since 1.0.5)
but then ./launcher bootstrap app fails with:
Gem::ConflictError: Unable to activate omniauth-ldap-2.0.0, because omniauth-2.1.2 conflicts with omniauth (~> 1.8.1), rubyntlm-0.3.4 conflicts with rubyntlm (~> 0.6.2) (Gem::ConflictError)

[tormodvolden]

Does this one need updating too? https://rubygems.org/gems/omniauth-ldap/versions/2.0.0 (it says omniauth ~> 1.8.1) See also omniauth/omniauth-ldap#91

I tried to redirect my own discourse-ldap-auth fork to use my own fork of omniauth-ldap but I am not sure how dependencies and versions are collected. AFAICS I cannot specify a git source in plugin.rb, so I can only get omniauth-ldap from rubygems.org.

[tormodvolden]

Since omniauth-ldap is basically 3 small files, and the repo looks not very active, maybe it would be at least a workaround for us to include it in discourse-ldap-auth but I don't have the ruby-fu needed.

EDIT: Actually just 2 files: lib/omniauth-ldap/adaptor.rb and lib/omniauth/strategies/ldap.rb

[jonmbake]

@tormodvolden I'll look into this more today and get back to you.

[jonmbake]

@tormodvolden @Justinzobel Please review and try out PR fix: https://github.com/jonmbake/discourse-ldap-auth/pull/84/files.

[tormodvolden]

I rebuilt the Discourse app, simply adding "-b pull-in-omniauth-ldap" to the git clone command in containers/app.yml , and it seems to work fine. It was cloned before your recent net-ldap bump, so I have commit 495d59a.

Thanks a lot for this! Including these files adds more code maintenance for you, but when I see the current state of affairs in the rubygems community (see that omniauth-ldap issue I linked above) I think it is only good to reduce dependency on more packages and people.

[bvarick]

This worked great for me in v3.4.1

Thanks!