Skip to content

Conversation

mothepro
Copy link
Contributor

@mothepro mothepro commented Oct 10, 2025

The site content is a demo of an open source package to verify bitcoin signed messages. Cryptographically verify messages signed by Bitcoin private keys.

@mothepro mothepro changed the title Update cnames_active.js verify-bitcoin-message.org.js Oct 10, 2025
@MattIPv4 MattIPv4 changed the title verify-bitcoin-message.org.js verify-bitcoin-message.js.org Oct 10, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@MattIPv4
Copy link
Member

Also, I think it'd be beneficial for your site to have documentation on actually using the NPM package. Currently, it seems to just be a site that uses JavaScript, which doesn't usually qualify for a JS.org subdomain (though I see in the repo that this is actually an NPM package as well).

@indus
Copy link
Member

indus commented Oct 10, 2025

Also, I think it'd be beneficial for your site to have documentation on actually using the NPM package. Currently, it seems to just be a site that uses JavaScript, which doesn't usually qualify for a JS.org subdomain (though I see in the repo that this is actually an NPM package as well).

@mothepro ☝️ That would shift the emphasis toward JavaScript developers as the target audience. Right now, it seems to be aimed at Bitcoin users, who may not care about the programming language at all.

@mothepro
Copy link
Contributor Author

mothepro commented Oct 11, 2025

Fixed!

Also, I think it'd be beneficial for your site to have documentation on actually using the NPM package. Currently, it seems to just be a site that uses JavaScript, which doesn't usually qualify for a JS.org subdomain (though I see in the repo that this is actually an NPM package as well).

☝️ shift the emphasis toward JavaScript developers as the target audience. Right now, it seems to be aimed at Bitcoin users, who may not care about the programming language at all.

Updated the homepage to have documentation for various methods including js and the library.

@mothepro mothepro requested a review from MattIPv4 October 11, 2025 04:47
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed invalid labels Oct 11, 2025
@indus
Copy link
Member

indus commented Oct 11, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@mothepro
Copy link
Contributor Author

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work. FYI: #7853 (comment) / #8532 (comment)

Verified that this works. Thanks.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 12, 2025
@indus
Copy link
Member

indus commented Oct 12, 2025

@indus indus merged commit 3731bdf into js-org:master Oct 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants