Skip to content

nb-scraper.js.org #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

nb-scraper.js.org #9861

merged 2 commits into from
Jun 13, 2025

Conversation

ErRickow
Copy link
Contributor

@ErRickow ErRickow commented Jun 12, 2025 •
edited
Loading

The site content is Documentation for NB-Scraper Content

@ErRickow
nb-scraper.js.org
ea94ad8 
register again with new deployment
@ErRickow
Copy link
Contributor Author

im i doing something wrong?

MattIPv4
MattIPv4 requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, your entry needs to be added to cnames_active.js in alphabetical order (- sorts above a).

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed invalid labels Jun 12, 2025
@indus
Copy link
Member

indus commented Jun 12, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@ErRickow
Copy link
Contributor Author

oke done, thanks for fast activate the subdomain

@indus
Copy link
Member

indus commented Jun 12, 2025 via email •
edited
Loading

@indus indus merged commit 42c793c into js-org:master Jun 13, 2025
2 checks passed
@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees

No one assigned

Labels

add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ErRickow @indus @MattIPv4