Skip to content

Fix pin versions nyc version for testing on old versions of node <= 9 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix pin versions nyc version for testing on old versions of node <= 9 #318

merged 1 commit into from
Mar 27, 2024

Conversation

@carpasse
Copy link
Contributor

@carpasse carpasse commented Mar 26, 2024 •
edited
Loading

Closes #317
Same fix as jshttp/http-errors#109

@carpasse
Copy link
Contributor Author

carpasse commented Mar 26, 2024 •
edited
Loading

I've also removed Node.js v0.6 from the ci-tests GH action because it fails to install. I've checked the ci-tests action in http-errors and it is not there probably because of similar reasons.

Screenshot 2024-03-26 at 10 06 08

@carpasse carpasse changed the title ci: pin versions nyc version for testing on old versions of node <= 9 Pin versions nyc version for testing on old versions of node <= 9 Mar 26, 2024
@carpasse carpasse changed the title Pin versions nyc version for testing on old versions of node <= 9 Fix pin versions nyc version for testing on old versions of node <= 9 Mar 26, 2024
@carpasse
Copy link
Contributor Author

carpasse commented Mar 26, 2024

Node 0.6 run was probably canceled because the other builds failed. I will add it back and test.

@carpasse carpasse force-pushed the ci/fix_test_in_node_8_and_9 branch from 874344f to e4e295c Compare March 26, 2024 09:27
@carpasse
Copy link
Contributor Author

carpasse commented Mar 26, 2024

The build doesn't seem to finish after adding back node version 0.6
I had to cancel it after 8 min https://github.com/carpasse/mime-db/actions/runs/8433679841/job/23095235917
Screenshot 2024-03-26 at 10 38 59

@dougwilson @UlisesGascon should I remove node.js version 0.6 from the ci-tests? It will be in sync with http-errors ci-tests.yml action

@UlisesGascon
Copy link
Member

UlisesGascon commented Mar 27, 2024

I enabled CI to run on this PR. Let's see how the patch works 👍

UlisesGascon
UlisesGascon approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carpasse Awesome work!

👏 👏 CI is green again! https://github.com/jshttp/mime-db/actions/runs/8433680265

@UlisesGascon UlisesGascon merged commit 850ad28 into jshttp:master Mar 27, 2024
@carpasse carpasse deleted the ci/fix_test_in_node_8_and_9 branch March 27, 2024 16:32
@InsafInhaam InsafInhaam mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken tests for Node@8 and Node@9

2 participants

@carpasse @UlisesGascon