Skip to content

Conversation

@QSchulz
Copy link
Contributor

@QSchulz QSchulz commented Jan 20, 2025

…mples page

A small typo made its way to the website in commit 72ae168 ("Added navigation buttons in other sections of website (#1218)"), let's fix that mistake.

Fixes: 72ae168 ("Added navigation buttons in other sections of website (#1218)")

What kind of change does this PR introduce?

Fixes a typo.

Issue Number:
Do I really need to open an issue for just this typo?

Screenshots/videos:

https://json-schema.org/learn/json-schema-examples

If relevant, did you update the documentation?

Only doc was changed.

Summary

Fixing typo, see https://json-schema.org/learn/json-schema-examples, bottom right for the next chapter: JSON Scehma Glossary.

Does this PR introduce a breaking change?

No?

Cc @json-schema-org/docs-team

…mples page

A small typo made its way to the website in commit 72ae168 ("Added
navigation buttons in other sections of website (json-schema-org#1218)"), let's fix
that mistake.

Fixes: 72ae168 ("Added navigation buttons in other sections of website (json-schema-org#1218)")
Signed-off-by: Quentin Schulz <[email protected]>
@QSchulz QSchulz requested a review from a team as a code owner January 20, 2025 12:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@github-actions
Copy link

github-actions bot commented Jan 20, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 2ef22b6

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (2ef22b6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QSchulz for the fix

LGTM 👍🏻

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
@benjagm benjagm merged commit ddad094 into json-schema-org:main Feb 1, 2025
11 checks passed
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

Congratulations, @QSchulz for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge PR that already has two approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants