chore: Update supported draft versions for Java Generator from code #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
approved these changes
Nov 6, 2023
Julian
added a commit
that referenced
this pull request
Nov 6, 2023
This doesn't *seem* like it should matter -- in that this workflow was tested as-is on a different repository as part of building it, and ran successfully. Furthermore, the docs for the permissions property in GitHub (at https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs) say: You can use permissions either as a top-level key, to apply to all jobs in the workflow, or within specific jobs. When you add the permissions key within a specific job, all actions and run commands within that job that use the GITHUB_TOKEN gain the access rights you specify. so, top-level seems like it's supposed to work fine. And yet, in the "Set up job" step of #206, the permissions for PullRequest are shown as: PullRequest: read (https://github.com/json-schema-org/website/actions/runs/6762327321/job/18401399964?pr=206#step:1:18 though that link won't last forever). Let's see at least if this changes that... Refs: #173
|
Thanks a lot for updating the information @CarstenWickner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Draft 2020-12 in the
victools:jsonschema-generatorlibrary was introduced end of 2021; support for Draft 6 even before that.Merely updating the reference here.