Skip to content

Fix for ProgressToken typing #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix for ProgressToken typing #821

merged 1 commit into from
Aug 25, 2020

Conversation

@ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Aug 25, 2020

refs: #688
closes #651

@ZacLN ZacLN added this to the Next Patch milestone Aug 25, 2020
@ZacLN ZacLN self-assigned this Aug 25, 2020
@aviatesk
Copy link
Member

aviatesk commented Aug 25, 2020

lgtm

@pfitzseb pfitzseb merged commit 4a581fb into master Aug 25, 2020
@ZacLN ZacLN deleted the progresstoken branch August 25, 2020 09:04
@ZacLN ZacLN mentioned this pull request Aug 27, 2020
Closed
@Gijs-Koot Gijs-Koot mentioned this pull request Oct 21, 2020
Closed
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees

@ZacLN ZacLN

Labels

bug non-vscode

Projects

None yet

Milestone

Next Bugfix Release

Development

Successfully merging this pull request may close these issues.

MethodError: no method matching Union{Int64, String}(::String)

4 participants

@ZacLN @aviatesk @pfitzseb