Remove vecdot #245
Merged
Remove vecdot #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Nov 7, 2018
oxinabox
reviewed
Nov 7, 2018
oxinabox
reviewed
Nov 7, 2018
iamed2
reviewed
Nov 7, 2018
ararslan
force-pushed
the
aa/vecdot
branch
2 times, most recently
from
e43ba22 to
22caba8
Compare
|
@ararslan what's left to do here? |
|
I need to change this back to something like it was when I first pushed the branch to ensure that we don't end up using broadcast behaviors like extending singleton dimensions, as Eric noted. |
The `vecdot` function was deprecated in favor of `dot` in Julia PR 27401; `dot` on matrices now treats them like vectors. The change here updates our extension of `dot` to match this behavior and deprecates `vecnorm`.
|
What if the |
|
Those aren't supported by Convex, which is documented and assumed but not strictly enforced. |
|
Uh. Okay then I guess. |
iamed2
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vecdotfunction was deprecated in favor ofdotin JuliaLang/julia#27401;doton matrices now treats them like vectors.The change here updates our extension of
dotto match this behavior and deprecatesvecnorm.