Skip to content

Allow configuring execution mode of dynamic tests and containers #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2025
Merged

Allow configuring execution mode of dynamic tests and containers #4621

merged 11 commits into from
Oct 7, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jun 5, 2025 •
edited
Loading

Overview

The new methods allow configuring the execution mode of dynamic tests
and containers as well as the default child execution mode for dynamic
containers in addition to all previously existing properties.

Resolves #2497.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jun 5, 2025
@marcphilipp marcphilipp linked an issue Jun 5, 2025 that may be closed by this pull request
Parallelization control of DynamicNode #2497
Closed
This was referenced Jun 5, 2025
Closed
Open
@marcphilipp marcphilipp force-pushed the marc/2497-dynamic-test-api-proposal branch from 7c8f22d to fb590bf Compare June 5, 2025 10:27
@marcphilipp marcphilipp force-pushed the marc/2497-dynamic-test-api-proposal branch from fb590bf to 2815054 Compare August 14, 2025 14:19
@marcphilipp
Add new factory methods to DynamicTest and DynamicContainer
199878d 
The new methods allow configuring the execution mode of dynamic tests
and containers as well as the default child execution mode for dynamic
containers in addition to all previously existing properties.
@marcphilipp
Rename to executionMode
484bc61
@marcphilipp
Add executionCondition() to Configuration interface
300b182 
Issue: #4620
@marcphilipp marcphilipp force-pushed the marc/2497-dynamic-test-api-proposal branch from 2815054 to bae2aac Compare October 2, 2025 12:04
@marcphilipp
Simplify
286c786 
* Remove `executionCondition` due to package cycle
* Use `self()` pattern for builders to avoid duplication
* Make `Configuration` `sealed`
@marcphilipp marcphilipp force-pushed the marc/2497-dynamic-test-api-proposal branch from bae2aac to 286c786 Compare October 2, 2025 12:05
sormuras
sormuras reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@sormuras sormuras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API and implementation looks good - API documentation and tests are in the works?

Good to see that the former code can be rewritten to use the new API.

@marcphilipp
Copy link
Member Author

API documentation and tests are in the works?

Not yet. I first wanted to get some feedback on the API.

@marcphilipp marcphilipp changed the title Add new factory methods to DynamicTest and DynamicContainer Allow configuring execution mode of dynamic tests and containers Oct 7, 2025
@marcphilipp marcphilipp marked this pull request as ready for review October 7, 2025 09:47
@marcphilipp marcphilipp requested a review from sormuras October 7, 2025 09:47
@marcphilipp marcphilipp merged commit 1f7be03 into main Oct 7, 2025
16 checks passed
@marcphilipp marcphilipp deleted the marc/2497-dynamic-test-api-proposal branch October 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sormuras sormuras sormuras approved these changes

Assignees

@marcphilipp marcphilipp

Labels
theme: concurrency theme: dynamic tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelization control of DynamicNode
2 participants
@marcphilipp @sormuras