Fix rename_file and delete_file to handle hidden files properly

[yacchin1205]

In working on the Pull Request jupyter/notebook#6609 , I found that the tests for hidden files was broken, so that I fixed the tests and found more problems to fix.

Some mistakes regarding the tests are as follows (for example, see test_400 intests/services/contents/test_manager.py https://github.com/jupyter-server/jupyter_server/blob/main/tests/services/contents/test_manager.py#L329-L342 ):

• There is the try ... except in with pytest.raises(HTTPError) , but actually the exception is raised by the cm.new before the try and never performs the rename_file.
• The old_path or new_path is set to the return value of cm._get_os_path() (it seems an absolute path), but I assume that rename_file and delete_file expects relative paths.

When I fixed the test, I found the following new problems:

• In AsyncFileContentsManager rename_file and delete_file, it is not checked if a path is a hidden file or not.
• In FileContentsManager delete_file, the existence check has been made before determining whether the file is hidden.(This looks like the hidden check should be done first, as seen in rename_file).

So I also fixed these problems.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (28577cf) to head (6958baa).
Report is 295 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   75.69%   75.69%   -0.01%     
==========================================
  Files          63       63              
  Lines        8222     8226       +4     
  Branches     1634     1636       +2     
==========================================
+ Hits         6224     6227       +3     
- Misses       1572     1574       +2     
+ Partials      426      425       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blink1073]

Thank you!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[blink1073]

@meeseeksdev please backport to 1.x