Attempt to fix https://github.com/jupyter/jupyter_core/issues/442 #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Oct 8, 2025
| raise OSError(msg, errno.ENOENT) | ||
| p = Popen([cmd_path] + argv[1:]) # noqa: S603 | ||
| # Quoting path in Windows | ||
| cmd_line = f'"{cmd_path}"' + "".join(f' "{arg}"' for arg in argv[1:]) |
There was a problem hiding this comment.
This definitely will not be correct when arg contains quotes. Passing a list to Popen should result in proper quoting. If it doesn't, I think this is a bug in Python itself.
Instead of building quoted strings by hand, we should always use libraries like shlex to make sure it's done correctly or in a platform-independent way (in fact, that is why we pass a list to Popen, so I'm not sure what's going wrong here)
Can you check if Popen(["some path", "with spaces"]) works for you without any Jupyer calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug #442, which occur because Windows paths are not quoted properly. If the user path has special chararacters ( parenthesis or spaces), jupyter_core breaks.