Skip to content

Conversation

@gjmooney
Copy link
Contributor

Fix for #1353. Adds a check for the validity of the lastAuthor information, and if the information isn't valid the author form is displayed again.

@github-actions
Copy link

Binder 👈 Launch a Binder on branch gjmooney/jupyterlab-git/display_author_dialog_again

@jtpio jtpio added the bug label Oct 22, 2024
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just checked on Binder and it seems to be working well 👍

jupyterlab-git-config-dialog.webm

Looks like the notification not going away is not related and could be tracked separately.

@jtpio jtpio linked an issue Oct 22, 2024 that may be closed by this pull request
@jtpio jtpio merged commit 9931e2f into jupyterlab:main Oct 22, 2024
8 of 10 checks passed
@gjmooney gjmooney deleted the display_author_dialog_again branch October 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git config dialog is only displayed once

2 participants