Api proposal : the store state's type is inferred by the creation method #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables DevStore to lift the type with any Creator.
AngusMorton
approved these changes
Mar 28, 2017
|
Hello friends, I've ben waiting a bit for more feedback but I guess I can merge it now. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
▲ ▲ ▲ Api update proposal ▲ ▲ ▲
Api proposal: the store state's type is inferred by the creation method and not the Creator object. These approaches are similar, the former is more functional-like when the latter is more OO-like.
But the functional one makes is actually easier to implement the dev-store https://github.com/glung/jvm-redux-devtools-instrument
Here is an implementation example : glung/redux-java#21
@pardom @beyondeye I am opening the debate again : )