Refine from_f function documentation and add tests #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation and added tests for from_f function.
|
@orhun kindly review the PR, when possible. Thanks ! |
orhun
approved these changes
Oct 25, 2025
Co-authored-by: Orhun Parmaksız <[email protected]>
orhun
approved these changes
Oct 26, 2025
|
@orhun can you please merge the PR so that its counted as an hacktoberfest contributions. |
|
I don't have permissions to merge on this repo. (I don't know why I was pinged as a code reviewer in the first place :D) |
|
Thanks for approving the changes, @orhun! |
|
I think you already tagged them in the original issue |
Kinda funny and based that you still reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the incorrect panic documentation in
Key::from_fand adds tests to verify behavior.Resolves #108