Skip to content

Conversation

@tkalfigo
Copy link

Major 1) Passes specific error name when creating instance of generic JwtParseError class.
Useful to end user to know precise error type and not just the message so he
can take additional action depending on it.
Major 2) create() respects user provided 'exp' timestamp in claims param over the default of one hour from now.
Minor: Indentation/formatting.

tkalfigo added 2 commits July 26, 2015 16:37
Passes specific error name when creating instance of generic JwtParseError class.
Useful to end user to know precise error type and not just the message so he
can take additional action depending on it.
Upon creating a new JWT, user can pass the 'exp' timestamp through the
claims parameter and it will be respected instead of the default
of 1 hour from the present.
@gyszalai
Copy link

gyszalai commented Sep 7, 2016

@robertjd Please merge this...

@typerandom
Copy link
Contributor

@tkalfigo We're very thankful for this PR. But unfortunately it's quite old (over a year) and contains too many changes to just merge in.

Instead I've created a few new issues that consolidate the changes that were seen in this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants