Fix incidental hidding of the moved element. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mouseup is followed by mousedown, without mousemove, and there is a custom helper, the moved element was left hidden after mouseup.
kamilkp
added a commit
that referenced
this pull request
Sep 19, 2014
Fix incidental hidding of the moved element.
kamilkp
added a commit
that referenced
this pull request
Jan 13, 2016
fix unintended side effects from PR-#9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mouseup is followed by mousedown, without mousemove,
and there is a custom helper,
the moved element was left hidden after mouseup.
The fix makes sure that if move was not executed, the class sv-visibility-hidden is removed from the target element.
You can observe the bug by clicking on a row from Custom Helpers demo. After click the row disappears.