Skip to content

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Apr 4, 2023

Summary

Add shutdown support to generated shared informer factories. This matches changes introduce upstream after our 1.24 rebase.

Related issue(s)

Part of kcp-dev/kcp#2772

@openshift-ci openshift-ci bot requested review from fabianvf and njhale April 4, 2023 17:37
@ncdc
Copy link
Member Author

ncdc commented Apr 4, 2023

/hold

We'll want to sequence getting the suite of 1.26 PRs merged and we're not ready for that yet.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
ncdc added 3 commits April 18, 2023 14:04
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc ncdc changed the title ✨ Add shutdown support to shared informer factory ✨ Update to Kubernetes 1.26 Apr 18, 2023
@ncdc
Copy link
Member Author

ncdc commented Apr 18, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@ncdc
Copy link
Member Author

ncdc commented Apr 18, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7e515e7 into kcp-dev:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants