✨ k/k 1.31.0 rebase #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
dco-signoff: yes
mjudeikis
commented
Aug 17, 2024
kcp-ci-bot
added
the
do-not-merge/work-in-progress
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
mjudeikis
force-pushed
the
1.31.0-prep
branch
3 times, most recently
from
4969f43 to
ad2daa2
Compare
mjudeikis
force-pushed
the
1.31.0-prep
branch
from
ad2daa2 to
b352bc4
Compare
embik
approved these changes
Sep 10, 2024
|
LGTM label has been added. Git tree hash: fc304296f4af40b279cb31aec95cf54cddf06ee2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rebase to 1.31.
Changes:
genclient:skipVerbs=list,watch. If skipped, on our end we skip List, Watch and DeleteCollections. It should be just List and Watch. Need to fix this or redo our generatorsdef.Strict = falseas we (k/k) changed some tags where now they aregroup=, meaning its not full key-value-pair. This passes the validation as its non-strict mode. This could have consequences that we miss some API groups in the future.In general, we should see how to make these generators closer to upstream v2 as now they are bespoke solutions. Or live with a bespoke solution. I would better invest time in refactoring them while we have time, and it's not a hard blocker for rebase.
Related issue(s)
Fixes #
Release Notes