✨ Syncer: support multiple shards #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Member
Author
|
/test e2e-shared |
davidfestal
force-pushed
the
shard-syncer
branch
from
142bba7 to
8e8c714
Compare
Member
Author
|
/test e2e-sharded e2e-shared e2e |
Member
Author
|
/test e2e-sharded |
Member
Author
|
/retest |
davidfestal
force-pushed
the
shard-syncer
branch
from
8e8c714 to
043dcb6
Compare
davidfestal
added
the
area/transparent-multi-cluster
davidfestal
force-pushed
the
shard-syncer
branch
5 times, most recently
from
0b4360c to
5287815
Compare
Member
Author
|
/retest |
Member
Author
|
/test e2e-sharded |
1 similar comment
Member
Author
|
/test e2e-sharded |
davidfestal
force-pushed
the
shard-syncer
branch
from
5287815 to
5807112
Compare
openshift-merge-robot
added
the
needs-rebase
davidfestal
force-pushed
the
shard-syncer
branch
from
5807112 to
2b66e82
Compare
openshift-merge-robot
removed
the
needs-rebase
davidfestal
force-pushed
the
shard-syncer
branch
from
2b66e82 to
9cefdf9
Compare
sttts
reviewed
Mar 2, 2023
sttts
reviewed
Mar 2, 2023
sttts
reviewed
Mar 2, 2023
sttts
reviewed
Mar 2, 2023
| SyncerClient kcpdynamic.ClusterInterface | ||
| SyncerDDSIF *informer.DiscoveringDynamicSharedInformerFactory | ||
| UpsyncerClient kcpdynamic.ClusterInterface | ||
| UpsyncerDDSIF *informer.DiscoveringDynamicSharedInformerFactory |
Member
There was a problem hiding this comment.
what are these? Upstream/downstream? Why a new concept?
Member
Author
There was a problem hiding this comment.
There are shards only for upstream (== KCP)
Member
Author
There was a problem hiding this comment.
Just gathering the shard-related upstream clients and informers for both the Syncer and UpSyncer.
Naming suggestion welcomed :-)
sttts
reviewed
Mar 2, 2023
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
... Signed-off-by: David Festal <[email protected]>
... only temporary, before we implement Syncer service account replication. Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
shard-syncer
branch
from
e227bcd to
1329ae7
Compare
davidfestal
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ncdc
reviewed
Apr 6, 2023
ncdc
reviewed
Apr 6, 2023
ncdc
reviewed
Apr 6, 2023
ncdc
reviewed
Apr 6, 2023
ncdc
reviewed
Apr 6, 2023
Signed-off-by: David Festal <[email protected]>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Syncer in order to make it shard-aware (supporting multiple shards)
Related issue(s)
Fixes #2832