Rebase to kubernetes v1.32.3 #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Also replaced k8s.io/apiserver/pkg/util/version import that is now removed with its correct path k8s.io/component-base/version. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Ran:
make codegen
On-behalf-of: @SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
garbagecollector.Run now requires an intial timeout argument. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
… feature gate See kubernetes/kubernetes#127058 On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
The feature gate is now stable and removed. See kubernetes/kubernetes#126645 On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
k8s.io/kubernetes/pkg/controlplane/apiserver/options/options.Complete() has a different signature that includes a ctx, and so we need to wire it to its callers. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…ount-signing-endpoint On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
coordination.k8s.io/v1alpha2 replaced v1alpha1, see k/k#127857. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…uginsInKube list On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
kcp-ci-bot
added
release-note
gman0
added
kind/feature
1 task
Kubernetes v1.32 implicitly removes ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding from admissionregistration.k8s.io/v1alpha in accordance with APILifecycle policy. This commit removes the relevant CRDs, informers and APIExport builtin types, and also removes the admissionregistration.k8s.io/v1alpha1 override from pkg/server/options/options.go. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
This is to be in line with kubernetes/kubernetes#130136 On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
gman0
force-pushed
the
updates-kcp-1.32.3
branch
from
3b10a1b to
90b3b75
Compare
Member
|
/retest |
embik
approved these changes
Apr 28, 2025
Member
embik
left a comment
embik
left a comment
There was a problem hiding this comment.
LGTM, will leave final approval up for a while if someone else wants to review as well.
Contributor
|
LGTM label has been added. Git tree hash: ed0b1c3eb374b6393ef305f574724a5547bd45bd
|
Member
|
/retest |
ntnn
approved these changes
Apr 28, 2025
Contributor
|
@ntnn: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR syncs kcp to be in line with k8s v1.32.3.
Things of note:
admissionregistration.k8s.io/v1alpha1admissionregistration.k8s.io/v1alpha1API is no longer served by defaultOther TODO items that will need to be worked on after the rebase:
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #3209
Release Notes