Skip to content

Adds access key service descriptions #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

deweller
Copy link

No description provided.

@EmilyShepherd EmilyShepherd mentioned this pull request Mar 13, 2017
Copy link

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the docblock definitions for the methods in \KeenIO\Client\KeenIOClient

Example

 * @method array getProjects(array $args = array()) {@command KeenIO getProjects}
 * @method array getProject(array $args = array()) {@command KeenIO getProject}

@jaketoolson
Copy link

Any updates on adding this!?

@tbarn
Copy link
Contributor

tbarn commented Oct 2, 2017

@mglaman wanna update your review?

@tbarn
Copy link
Contributor

tbarn commented Oct 2, 2017

Thanks, @mglaman! ✨ 💖

@deweller I'd feel more comfortable merging this if docs were added to the readme. Think you could add some?

Some examples are: https://keen.io/docs/api/?javascript#access-keys
Also, this one isn't complete, but definitely a good start: https://github.com/keenlabs/keen-gem#access-keys

@deweller
Copy link
Author

deweller commented Oct 3, 2017

I've abandoned this pull request. But you are welcome to use the code if you find it helpful.

@deweller deweller closed this Oct 3, 2017
@mglaman
Copy link

mglaman commented Oct 3, 2017

I am also not actively using the SDK or this PR patch anymore to push forward changes. Took too long for feedback and activity from Keen.

@tbarn
Copy link
Contributor

tbarn commented Oct 3, 2017

@deweller @mglaman totally understandable. And I apologize for how long it took for movement on this. I'm going to be working on improving this in the future for all our SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants