bump to RN0.71 & Appium 2 beta #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadeinFrance
reviewed
Feb 9, 2023
|
|
||
| let driver; | ||
| const config = { | ||
| path: '/wd/hub', |
There was a problem hiding this comment.
should be / because /wd/hub returns HTTP 404
MadeinFrance
reviewed
Feb 9, 2023
There was a problem hiding this comment.
Great job for updating to the latest requirements of Appium. I think Webdriver should be initialized with
import {remote} from 'webdriverio';
See an example: https://github.com/webdriverio/webdriverio/blob/main/examples/appium/appium-draws-its-logo.mjs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the project be more relevant, let's update it all to match latest RN stable and Appium 2.
This work has been partially inspired by @MadeinFrance's feedback and PR (#3) and by the work we are doing in core in this PR: facebook/react-native#36267
Currently, for some god-forsaken reason the android test fails, but I want to merge this is so that fixes can be worked on top of the better shape of code.