Skip to content

selftests/bpf: enfoce SO_REUSEADDR in basic test servers #10204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: bpf-next_base
Choose a base branch
from
+23 −13
Open

selftests/bpf: enfoce SO_REUSEADDR in basic test servers #10204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fb9039
selftests/bpf: systematically add SO_REUSEADDR in start_server_addr
Tropicao Nov 5, 2025
5ab5116
selftests/bpf: use start_server_str rather than start_reuseport_serve…
Tropicao Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/testing/selftests/bpf/network_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ int settimeo(int fd, int timeout_ms)
int start_server_addr(int type, const struct sockaddr_storage *addr, socklen_t addrlen,
const struct network_helper_opts *opts)
{
int fd;

int on = 1, fd;

if (!opts)
opts = &default_opts;
Expand All @@ -111,6 +112,12 @@ int start_server_addr(int type, const struct sockaddr_storage *addr, socklen_t a
if (settimeo(fd, opts->timeout_ms))
goto error_close;

if (type == SOCK_STREAM &&
setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on))) {
log_err("Failed to enable SO_REUSEADDR");
goto error_close;
}

if (opts->post_socket_cb &&
opts->post_socket_cb(fd, opts->cb_opts)) {
log_err("Failed to call post_socket_cb");
Expand Down
27 changes: 15 additions & 12 deletions tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct subtest_cfg {
int client_egress_prog_fd;
int server_ingress_prog_fd;
char extra_decap_mod_args[TUNNEL_ARGS_MAX_LEN];
int *server_fd;
int server_fd;
};

struct connection {
Expand Down Expand Up @@ -135,24 +135,26 @@ static int run_server(struct subtest_cfg *cfg)
{
int family = cfg->ipproto == 6 ? AF_INET6 : AF_INET;
struct nstoken *nstoken;
struct network_helper_opts opts = {
.timeout_ms = TIMEOUT_MS
};

nstoken = open_netns(SERVER_NS);
if (!ASSERT_OK_PTR(nstoken, "open server ns"))
return -1;

cfg->server_fd = start_reuseport_server(family, SOCK_STREAM,
cfg->server_addr, TEST_PORT,
TIMEOUT_MS, 1);
cfg->server_fd = start_server_str(family, SOCK_STREAM, cfg->server_addr,
TEST_PORT, &opts);
close_netns(nstoken);
if (!ASSERT_OK_PTR(cfg->server_fd, "start server"))
if (!ASSERT_OK_FD(cfg->server_fd, "start server"))
return -1;

return 0;
}

static void stop_server(struct subtest_cfg *cfg)
{
free_fds(cfg->server_fd, 1);
close(cfg->server_fd);
}

static int check_server_rx_data(struct subtest_cfg *cfg,
Expand Down Expand Up @@ -188,7 +190,7 @@ static struct connection *connect_client_to_server(struct subtest_cfg *cfg)
return NULL;
}

server_fd = accept(*cfg->server_fd, NULL, NULL);
server_fd = accept(cfg->server_fd, NULL, NULL);
if (server_fd < 0) {
close(client_fd);
free(conn);
Expand Down Expand Up @@ -394,29 +396,30 @@ static void run_test(struct subtest_cfg *cfg)

/* Basic communication must work */
if (!ASSERT_OK(send_and_test_data(cfg, true), "connect without any encap"))
goto fail;
goto fail_close_server;

/* Attach encapsulation program to client */
if (!ASSERT_OK(configure_encapsulation(cfg), "configure encapsulation"))
goto fail;
goto fail_close_server;

/* If supported, insert kernel decap module, connection must succeed */
if (!cfg->expect_kern_decap_failure) {
if (!ASSERT_OK(configure_kernel_decapsulation(cfg),
"configure kernel decapsulation"))
goto fail;
goto fail_close_server;
if (!ASSERT_OK(send_and_test_data(cfg, true),
"connect with encap prog and kern decap"))
goto fail;
goto fail_close_server;
}

/* Replace kernel decapsulation with BPF decapsulation, test must pass */
if (!ASSERT_OK(configure_ebpf_decapsulation(cfg), "configure ebpf decapsulation"))
goto fail;
goto fail_close_server;
ASSERT_OK(send_and_test_data(cfg, true), "connect with encap and decap progs");

fail:
stop_server(cfg);
fail_close_server:
close_netns(nstoken);
}

Expand Down
Loading