libbpf: support custom SEC() handlers #2523

kernel-patches-bot · 2022-02-05T01:42:23Z

Pull request for series with
subject: libbpf: support custom SEC() handlers
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491

kernel-patches-bot · 2022-02-05T01:42:24Z

Master branch: 976a38e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

kernel-patches-bot · 2022-02-05T02:30:54Z

Master branch: 0908a66
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

kernel-patches-bot · 2022-02-05T20:34:12Z

Master branch: 9a3d1eb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

kernel-patches-bot · 2022-02-05T20:49:58Z

Master branch: 422ee58
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

kernel-patches-bot · 2022-02-07T16:19:22Z

Master branch: e91d280
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

kernel-patches-bot · 2022-02-07T20:22:35Z

Master branch: 128dac5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=611491
version: 2

Allow some BPF program types to support auto-attach only in subste of cases. Currently, if some BPF program type specifies attach callback, it is assumed that during skeleton attach operation all such programs either successfully attach or entire skeleton attachment fails. If some program doesn't support auto-attachment from skeleton, such BPF program types shouldn't have attach callback specified. This is limiting for cases when, depending on how full the SEC("") definition is, there could either be enough details to support auto-attach or there might not be and user has to use some specific API to provide more details at runtime. One specific example of such desired behavior might be SEC("uprobe"). If it's specified as just uprobe auto-attach isn't possible. But if it's SEC("uprobe/<some_binary>:<some_func>") then there are enough details to support auto-attach. Another improvement to the way libbpf is handling SEC()s would be to not require providing dummy kernel function name for kprobe. Currently, SEC("kprobe/whatever") is necessary even if actual kernel function is determined by user at runtime and bpf_program__attach_kprobe() is used to specify it. With changes in this patch, it's possible to support both SEC("kprobe") and SEC("kprobe/<actual_kernel_function"), while only in the latter case auto-attach will be performed. In the former one, such kprobe will be skipped during skeleton attach operation. Signed-off-by: Andrii Nakryiko <[email protected]>

Allow registering and unregistering custom handlers for BPF program. This allows user applications and libraries to plug into libbpf's declarative SEC() definition handling logic. This allows to offload complex and intricate custom logic into external libraries, but still provide a great user experience. One such example is USDT handling library, which has a lot of code and complexity which doesn't make sense to put into libbpf directly, but it would be really great for users to be able to specify BPF programs with something like SEC("usdt/<path-to-binary>:<usdt_provider>:<usdt_name>") and have correct BPF program type set (BPF_PROGRAM_TYPE_KPROBE, as it is uprobe) and even support BPF skeleton's auto-attach logic. In some cases, it might be even good idea to override libbpf's default handling, like for SEC("perf_event") programs. With custom library, it's possible to extend logic to support specifying perf event specification right there in SEC() definition without burdening libbpf with lots of custom logic or extra library dependecies (e.g., libpfm4). With current patch it's possible to override libbpf's SEC("perf_event") handling and specify a completely custom ones. Further, it's possible to specify a generic fallback handling for any SEC() that doesn't match any other custom or standard libbpf handlers. This allows to accommodate whatever legacy use cases there might be, if necessary. See doc comments for libbpf_register_prog_handler() and libbpf_unregister_prog_handler() for detailed semantics. Signed-off-by: Andrii Nakryiko <[email protected]>

Add a selftest validating various aspects of libbpf's handling of custom SEC() handlers. It also demonstrates how libraries can ensure very early callbacks registration and unregistration using __attribute__((constructor))/__attribute__((destructor)) functions. Signed-off-by: Andrii Nakryiko <[email protected]>

kernel-patches-bot · 2022-02-07T22:14:17Z

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=611491 expired. Closing PR.

…arations) Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations kernel-patches#761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations kernel-patches#2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations kernel-patches#2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations kernel-patches#2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations kernel-patches#2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations kernel-patches#2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations kernel-patches#2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations kernel-patches#2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer <[email protected]> Signed-off-by: NipaLocal <nipa@local>

…arations) Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations kernel-patches#761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations kernel-patches#2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations kernel-patches#2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations kernel-patches#2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations kernel-patches#2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations kernel-patches#2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations kernel-patches#2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations kernel-patches#2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer <[email protected]> Reviewed-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>

kernel-patches-bot added bpf-next new V2 labels Feb 5, 2022

kernel-patches-bot force-pushed the series/611489=>bpf-next branch from 8dbd2e6 to 698998b Compare February 5, 2022 02:30

kernel-patches-bot force-pushed the series/611489=>bpf-next branch from 698998b to d87dbe8 Compare February 5, 2022 20:34

kernel-patches-bot force-pushed the series/611489=>bpf-next branch from d87dbe8 to 3d895ed Compare February 5, 2022 20:50

kernel-patches-bot force-pushed the bpf-next branch from 422ee58 to e91d280 Compare February 7, 2022 16:11

kernel-patches-bot force-pushed the series/611489=>bpf-next branch from 3d895ed to c513c2f Compare February 7, 2022 16:19

adding ci files

eb53618

anakryiko added 3 commits February 7, 2022 12:22

kernel-patches-bot force-pushed the series/611489=>bpf-next branch from c513c2f to 9254c93 Compare February 7, 2022 20:22

kernel-patches-bot added changes-requested and removed new labels Feb 7, 2022

kernel-patches-bot closed this Feb 7, 2022

kernel-patches-bot deleted the series/611489=>bpf-next branch February 10, 2022 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

libbpf: support custom SEC() handlers #2523

libbpf: support custom SEC() handlers #2523

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

libbpf: support custom SEC() handlers #2523

libbpf: support custom SEC() handlers #2523

Uh oh!

Conversation

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 5, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

kernel-patches-bot commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants