Skip to content

kernel: Reboot device if kernel panics #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

kernel: Reboot device if kernel panics #791

merged 1 commit into from
Oct 31, 2024

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Oct 31, 2024 •
edited
Loading

The worst way of handling a kernel crash is to do nothing at all.

This fix #740

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal
kernel: Reboot device if kernel panics
b0f4192 
The worst way of handling a kernel crash is to do nothing at all.
@mattiaswal mattiaswal requested a review from troglobit October 31, 2024 14:57
troglobit
troglobit approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for fixing this before the release 😎👍

For the future, and very minor, I think we should put all fix #num lines in the commit messages. It's easier to track backwards why we have certain lines of code/config.

@troglobit troglobit merged commit fb3c026 into main Oct 31, 2024
6 checks passed
@troglobit troglobit deleted the reboot-on-error branch October 31, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@troglobit troglobit troglobit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reboot on kernel failures

2 participants

@mattiaswal @troglobit