Skip to content

Fix text cursor display in Textbox. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

BFNOC
Copy link

@BFNOC BFNOC commented Jul 18, 2025

Before fix text cursor in notepad.exe:
截屏2025-07-18 22 22 15

After fix text cursor in notepad.exe:
截屏2025-07-18 22 21 06

@kirides
Copy link
Owner

kirides commented Jul 18, 2025

if i remember correctly this was intentional as otherwise a black cursor disappears on dark-themed windows, eg. VS Code, maybe there is a better way to fix this, perhaps by checking the bounding-box of the cursor in the image, and if it's mostly white-ish use black, or else white

Or figure out if there is a way to properly do it

@BFNOC
Copy link
Author

BFNOC commented Jul 19, 2025

I tried adding a detection function to determine the cursor color.
Also I fixed the problem of the animation color being wrong when the cursor state is busy.
Before fix busy cursor:
截屏2025-07-19 18 42 07
After fix busy cursor:
截屏2025-07-19 18 40 24
I would like to point out that the code was modified with the assistance of AI, I hope you don’t mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants