Remove native-tls feature
#1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazk
force-pushed
the
remove-native-tls
branch
from
8db9545 to
ac781ab
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 72.29% 72.29% -0.01%
==========================================
Files 65 65
Lines 4692 4688 -4
==========================================
- Hits 3392 3389 -3
+ Misses 1300 1299 -1
|
kazk
force-pushed
the
remove-native-tls
branch
from
ac781ab to
d9e70c1
Compare
kazk
force-pushed
the
remove-native-tls
branch
from
d9e70c1 to
76b2a7e
Compare
|
Thanks for fixing Clippy. I'll merge this after rebasing. |
Signed-off-by: kazk <[email protected]>
kazk
force-pushed
the
remove-native-tls
branch
from
76b2a7e to
ba989c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native-tlsfeature exists becausekubeused to depend onreqwest. It doesn't really make sense for us becauseopensslis required on all platforms anyway. It also doesn't work on macOS (#89 and #691), so the default was changed toopenssl-tlssince 0.71.0 (#863).This PR removes the feature as discussed in #863 (comment).
Closes #89
Closes #691