Skip to content

chore: Remove dependency on home crate, use std instead #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+10 −4
Merged

chore: Remove dependency on home crate, use std instead #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ either = "1.6.1"
form_urlencoded = "1.2.0"
futures = { version = "0.3.17", default-features = false }
hashbrown = "0.16.0"
home = "0.5.4"
hostname = "0.4"
http = "1.1.0"
http-body = "1.0.1"
Expand Down
3 changes: 1 addition & 2 deletions kube-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ gzip = ["client", "tower-http/decompression-gzip"]
client = ["config", "__non_core", "hyper", "hyper-util", "http-body", "http-body-util", "tower", "tower-http", "hyper-timeout", "chrono", "jsonpath-rust", "bytes", "futures", "tokio", "tokio-util", "either"]
jsonpatch = ["kube-core/jsonpatch"]
admission = ["kube-core/admission"]
config = ["__non_core", "pem", "home"]
config = ["__non_core", "pem"]
socks5 = ["hyper-util/client-proxy"]
http-proxy = ["hyper-util/client-proxy"]
unstable-client = []
Expand All @@ -45,7 +45,6 @@ workspace = true
[dependencies]
base64 = { workspace = true, optional = true }
chrono = { workspace = true, optional = true }
home = { workspace = true, optional = true }
serde = { workspace = true, features = ["derive"] }
serde_json.workspace = true
serde_yaml = { workspace = true, optional = true }
Expand Down
10 changes: 9 additions & 1 deletion kube-client/src/config/file_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,15 @@ fn ensure_trailing_newline(mut data: Vec<u8>) -> Vec<u8> {

/// Returns kubeconfig path from `$HOME/.kube/config`.
fn default_kube_path() -> Option<PathBuf> {
home::home_dir().map(|h| h.join(".kube").join("config"))
// Before Rust 1.85.0, `home_dir` would return wrong results on Windows, usage of the crate
// `home` was encouraged (and is what kube-rs did).
// Rust 1.85.0 fixed the problem (https://doc.rust-lang.org/1.85.0/std/env/fn.home_dir.html),
// Rust 1.87.0 removed the function deprecation.
// As the MSRV was bumped to 1.85.0 we are safe to use the fixed std function.
// Note: We intentionally use `allow` over `expect` to support compilation on Rust >= 1.87.0
// Note: This can be removed once the MSRV is bumped to >= 1.87.0
Comment on lines +668 to +669
Copy link
Member

@clux clux Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good comments 👍

#[allow(deprecated)]
std::env::home_dir().map(|h| h.join(".kube").join("config"))
}

mod base64serde {
Expand Down
Loading