Skip to content

Support jmespath for references with jmes: prefix #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support jmespath for references with jmes: prefix #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 63 additions & 37 deletions pkg/graph/lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"sort"
"strings"

"github.com/jmespath/go-jmespath"
"gomodules.xyz/jsonpath"
core "k8s.io/api/core/v1"
kerr "k8s.io/apimachinery/pkg/api/errors"
Expand Down Expand Up @@ -304,25 +305,19 @@ func (finder ObjectFinder) ResourcesFor(src *unstructured.Unstructured, e *Edge)
// TODO: check that namespacePath must be empty

var out []*unstructured.Unstructured

for _, reference := range e.Connection.References {
j := jsonpath.New("jsonpath")
j.AllowMissingKeys(true)
err := j.Parse(reference)
if err != nil {
return nil, fmt.Errorf("fails to parse reference %q between %s -> %s. err:%v", e.Connection.References, e.Src, e.Dst, err)
}
buf := new(bytes.Buffer)
err = j.Execute(buf, src.Object)
if err != nil {
return nil, fmt.Errorf("fails to execute reference %q between %s -> %s. err:%v", e.Connection.References, e.Src, e.Dst, err)
}
r := csv.NewReader(buf)
// Mapper.Comma = ';'
r.Comment = '#'
records, err := r.ReadAll()
if err != nil {
return nil, err
var records [][]string
var err error
if strings.HasPrefix(reference, "jmes:") {
records, err = execJmesPath(src.Object, reference[5:], e.Src, e.Dst)
if err != nil {
return nil, err
}
} else {
records, err = execJsonPath(src.Object, reference, e.Src, e.Dst)
if err != nil {
return nil, err
}
}
refs, err := ParseResourceRefs(records)
if err != nil {
Expand Down Expand Up @@ -509,25 +504,18 @@ func (finder ObjectFinder) ResourcesFor(src *unstructured.Unstructured, e *Edge)
rs := result.Items[i]

for _, reference := range e.Connection.References {

j := jsonpath.New("jsonpath")
j.AllowMissingKeys(true)
err := j.Parse(reference)
if err != nil {
return nil, fmt.Errorf("fails to parse reference %q between %s -> %s. err:%v", e.Connection.References, e.Src, e.Dst, err)
}

buf := new(bytes.Buffer)
err = j.Execute(buf, rs.Object)
if err != nil {
return nil, fmt.Errorf("fails to execute reference %q between %s -> %s. err:%v", e.Connection.References, e.Src, e.Dst, err)
}
r := csv.NewReader(buf)
// Mapper.Comma = ';'
r.Comment = '#'
records, err := r.ReadAll()
if err != nil {
return nil, err
var records [][]string
var err error
if strings.HasPrefix(reference, "jmes:") {
records, err = execJmesPath(rs.Object, reference[5:], e.Src, e.Dst)
if err != nil {
return nil, err
}
} else {
records, err = execJsonPath(rs.Object, reference, e.Src, e.Dst)
if err != nil {
return nil, err
}
}
refs, err := ParseResourceRefs(records)
if err != nil {
Expand Down Expand Up @@ -581,6 +569,44 @@ func (finder ObjectFinder) ResourcesFor(src *unstructured.Unstructured, e *Edge)
return nil, nil
}

func execJmesPath(data any, reference string, src, dst schema.GroupVersionKind) ([][]string, error) {
result, err := jmespath.Search(reference, data)
if err != nil {
return nil, fmt.Errorf("fails to execute jmes reference %q between %s -> %s. err:%w", reference, src, dst, err)
}
switch v := result.(type) {
case string:
return [][]string{{v}}, nil
case []string:
out := make([][]string, len(v))
for i, s := range v {
out[i] = []string{s}
}
return out, nil
case [][]string:
return v, nil
}
return nil, fmt.Errorf("invalid result type %T for jmes reference %q between %s -> %s", result, reference, src, dst)
}

func execJsonPath(data any, reference string, src, dst schema.GroupVersionKind) ([][]string, error) {
j := jsonpath.New("jsonpath")
j.AllowMissingKeys(true)
err := j.Parse(reference)
if err != nil {
return nil, fmt.Errorf("fails to parse reference %q between %s -> %s. err:%v", reference, src, dst, err)
}
buf := new(bytes.Buffer)
err = j.Execute(buf, data)
if err != nil {
return nil, fmt.Errorf("fails to execute reference %q between %s -> %s. err:%v", reference, src, dst, err)
}
r := csv.NewReader(buf)
// Mapper.Comma = ';'
r.Comment = '#'
return r.ReadAll()
}

func isConnected(conn rsapi.OwnershipLevel, obj *unstructured.Unstructured, owner *unstructured.Unstructured) bool {
switch conn {
case rsapi.Controller:
Expand Down