WIP: prow.sh: avoid creating paths unless really running tests #278
Conversation
verify-go-version.sh sources prow.sh to determine the desired Go version. This had the unintended side effect of creating one $GOPATH/pkg/csiprow.* directory per make invocation and triggered error messages when GOPATH was not set. Also, `go env GOPATH` is now used as fallback when not set explicitly.
|
@pohly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@pohly: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Was merged: kubernetes-csi/csi-release-tools#143 |
74502e54 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146 Bump actions/checkout from 4 to 5 5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f6242 Update go to 1.24.6 5ec1a52b use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7 Update CSI prow driver version to v1.17.0 0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af10153 update to go 1.24.4 f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 74502e544bc6a17820892c0d490e8f0b59462998
74502e54 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146 Bump actions/checkout from 4 to 5 5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f6242 Update go to 1.24.6 5ec1a52b use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7 Update CSI prow driver version to v1.17.0 0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af10153 update to go 1.24.4 f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 74502e544bc6a17820892c0d490e8f0b59462998
2 participants
verify-go-version.sh sources prow.sh to determine the desired Go
version. This had the unintended side effect of creating one
$GOPATH/pkg/csiprow.* directory per make invocation and triggered
error messages when GOPATH was not set.
Test PR. Do not merge.