Common leader election library

[msau42]

Let's standardize on using the Lease mechanism for all the sidecars, and try to have common arguments too.

cc @wongma7 @xing-yang

[msau42]

/kind feature

[xing-yang]

/assign @wackxu

[k8s-ci-robot]

@xing-yang: GitHub didn't allow me to assign the following users: wackxu.

Note that only kubernetes-csi members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wackxu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

I am 100% for standardizing leader election, there is just one glitch: it will pull lot of Kubernetes dependencies into this library. It will complicate rebases and releases - with new Kubernetes, one needs to update csi-lib-utils and external-provisioner-lib, wait until they release a new version and then bump their versions in all sidecars that use it. Is there a way how to do it better / faster?

[andrewsykim]

/assign

[andrewsykim]

It will complicate rebases and releases - with new Kubernetes, one needs to update csi-lib-utils and external-provisioner-lib, wait until they release a new version and then bump their versions in all sidecars that use it. Is there a way how to do it better / faster?

Can we go back to mono repos? 😆

[xing-yang]

Just read Jan's comments. I see what he meant. Right now this lib does not have dependency on kubernetes. Once we add this function in here, this lib will have dependencies on kubernetes. We need to sync up kubernetes versions all the way up to all sidecar containers that use this lib. I don't know if there's a better way. One alternative is to leave it to each sidecar container to implement this, but then we don't have a common lib to use.

[msau42]

/close
Done in #21

We can hopefully have better dependency management with go modules.

[k8s-ci-robot]

@msau42: Closing this issue.

In response to this:

/close
Done in #21

We can hopefully have better dependency management with go modules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.