sanity: use correct path during cleanup #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-csi#159 introduced the ability to use different paths for each tests via external commands or callbacks, but it missed two lines in the cleanup code which also have to use the actual paths instead of the configured paths.
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
sanity: use correct path during cleanup
stmcginnis
pushed a commit
to stmcginnis/csi-test
that referenced
this pull request
Oct 9, 2024
…indows-versions Remove Windows versions 1909 and 2004 which have reached EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#159 introduced the
ability to use different paths for each tests via external commands or
callbacks, but it missed two lines in the cleanup code which also have
to use the actual paths instead of the configured paths.