Skip to content

Conversation

nearora-msft
Copy link
Contributor

@nearora-msft nearora-msft commented Feb 15, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR is an extension to kubernetes-csi/csi-lib-utils#77 to send "migrated" label in the metrics

Which issue(s) this PR fixes:
Partially Addressed # kubernetes/kubernetes#98279

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Set the value of "migrated" field in the metrics to true or false to indicate if the call is a migration enabled feature or not

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @nearora-msft!

It looks like this is your first PR to kubernetes-csi/external-resizer 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-resizer has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nearora-msft. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2021
@nearora-msft
Copy link
Contributor Author

@Jiawei0227 Could you please look at this draft PR to see if things looks ok?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2021
@nearora-msft nearora-msft force-pushed the metrics-with-migrated-label branch 2 times, most recently from 54cc14b to a1c7b18 Compare February 17, 2021 07:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2021
@nearora-msft nearora-msft force-pushed the metrics-with-migrated-label branch from a1c7b18 to 979af1f Compare February 17, 2021 09:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2021
@nearora-msft nearora-msft force-pushed the metrics-with-migrated-label branch 2 times, most recently from 361f331 to fcbce6a Compare February 17, 2021 09:40
@nearora-msft nearora-msft marked this pull request as ready for review February 17, 2021 09:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2021
@Jiawei0227
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2021
@nearora-msft nearora-msft force-pushed the metrics-with-migrated-label branch from fcbce6a to 332520e Compare February 18, 2021 07:20
@Jiawei0227
Copy link
Contributor

/lgtm

I tested this in my dev environment and it is working. One thing to call out is #137 this need to be done otherwise the resize will not work. We need to do before the next resizer release

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@Jiawei0227
Copy link
Contributor

@msau42 for final approval.

@msau42
Copy link
Collaborator

msau42 commented Feb 18, 2021

/approve

@Jiawei0227 are you able to update csi-translation-lib now? We can use a specific hash I think

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, nearora-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 48112eb into kubernetes-csi:master Feb 18, 2021
pohly added a commit to pohly/external-resizer that referenced this pull request Mar 23, 2021
1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10
bff2fb7 prow.sh: KinD 0.10.0

git-subtree-dir: release-tools
git-subtree-split: 1d77cfcbf58617315d02509d96570f9721dcd6b8
pohly added a commit to pohly/external-resizer that referenced this pull request Mar 24, 2021
a1e1127 Merge pull request kubernetes-csi#139 from pohly/kind-for-kubernetes-latest
1c0fb09 prow.sh: use KinD main for latest Kubernetes
1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10
bff2fb7 prow.sh: KinD 0.10.0

git-subtree-dir: release-tools
git-subtree-split: a1e11275b5a4febd6ad21beeac730e22c579825b
dobsonj pushed a commit to dobsonj/external-resizer that referenced this pull request Oct 16, 2023
…ncy-openshift-4.14-ose-csi-external-resizer

Updating ose-csi-external-resizer images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants