-
Notifications
You must be signed in to change notification settings - Fork 147
feat: Add migrated label to metrics #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add migrated label to metrics #138
Conversation
Welcome @nearora-msft! |
Hi @nearora-msft. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Jiawei0227 Could you please look at this draft PR to see if things looks ok? |
54cc14b
to
a1c7b18
Compare
a1c7b18
to
979af1f
Compare
361f331
to
fcbce6a
Compare
/ok-to-test |
fcbce6a
to
332520e
Compare
/lgtm I tested this in my dev environment and it is working. One thing to call out is #137 this need to be done otherwise the resize will not work. We need to do before the next resizer release |
@msau42 for final approval. |
/approve @Jiawei0227 are you able to update csi-translation-lib now? We can use a specific hash I think |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, nearora-msft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10 bff2fb7 prow.sh: KinD 0.10.0 git-subtree-dir: release-tools git-subtree-split: 1d77cfcbf58617315d02509d96570f9721dcd6b8
a1e1127 Merge pull request kubernetes-csi#139 from pohly/kind-for-kubernetes-latest 1c0fb09 prow.sh: use KinD main for latest Kubernetes 1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10 bff2fb7 prow.sh: KinD 0.10.0 git-subtree-dir: release-tools git-subtree-split: a1e11275b5a4febd6ad21beeac730e22c579825b
…ncy-openshift-4.14-ose-csi-external-resizer Updating ose-csi-external-resizer images to be consistent with ART
What type of PR is this?
What this PR does / why we need it:
This PR is an extension to kubernetes-csi/csi-lib-utils#77 to send "migrated" label in the metrics
Which issue(s) this PR fixes:
Partially Addressed # kubernetes/kubernetes#98279
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: