- 
                Notifications
    
You must be signed in to change notification settings  - Fork 404
 
feat: Add migrated label to metrics #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add migrated label to metrics #475
Conversation
| 
           Welcome @nearora-msft!   | 
    
| 
           [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nearora-msft The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 
      Approvers can indicate their approval by writing   | 
    
| 
           Hi @nearora-msft. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.  | 
    
| 
           @Jiawei0227 Could you please look at this draft PR to see if things looks ok?  | 
    
| 
           @Jiawei0227 Is this PR needed? Snapshot is not supported by in-tree plugins.  | 
    
          
 Oh is that so? I will close this then.  | 
    
| 
           Yep, we do not need to add this for snapshot. Only the other three sidecars  | 
    
What type of PR is this?
What this PR does / why we need it:
his PR is an extension to kubernetes-csi/csi-lib-utils#77 to send "migrated" label in the metrics
Which issue(s) this PR fixes:
Fixes #
Partially Addressed # kubernetes/kubernetes#98279
Special notes for your reviewer:
Does this PR introduce a user-facing change?: