Fix snapshotter metrics server to use httpEndpoint when provided #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
Contributor
Author
|
/test pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20 |
Contributor
Author
|
Fixing release-4.0 in #498 |
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
release-4.0_cherrypick_f949f2be3b0f6446b6ffe786a7a372e21b415ccc
branch
from
c2f91ea to
600477f
Compare
Contributor
Author
|
/assign @xing-yang |
Collaborator
|
Can you add "Cherry-pick of #496" in the beginning of the release note? |
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cherry-pick of #496
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: