-
Notifications
You must be signed in to change notification settings - Fork 404
Update snapshotter and client modules #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @xing-yang |
|
Can you add a release note? |
|
Can you test installing the old CRDs (without the new field), creating a VolumeSnapshot using the old controller; then updating the CRDs and controller to the new ones, and make sure you can still access the VolumeSnapshot; also creating a VolumeSnapshot using the new CRD and new controller. |
@xing-yang Confirmed the above. Added the tests to the PR description. I'll be making changes to the Webhooks validation logic in a separate PR, so for now just tested that everything gets created as expected. |
|
In the testing step 4, can you add a note about the pending webhook change and the new field should be immutable? |
|
Can you also squash the commits? |
- Update snapshotter client module to v5 - Update go version in client modules to v1.17
87c64c4 to
d300796
Compare
Done! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -1,25 +1,57 @@ | |||
| module github.com/kubernetes-csi/external-snapshotter/client/v4 | |||
| module github.com/kubernetes-csi/external-snapshotter/client/v5 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. We actually need to update to client/v6. Client/v5 was cut earlier but we didn't update this link.
https://github.com/kubernetes-csi/external-snapshotter/releases/tag/client%2Fv5.0.0
Can you submit another PR to update this to module github.com/kubernetes-csi/external-snapshotter/client/v6?
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This PR updates the following modules:
This change is needed for the API updates in #665 to be available in external-provisioner code.
Testing:
ReadyToUseSourceVolumeModefield. NOTE: Webhook changes are still pending and this field will be made immutable in the future.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: