Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Conversation

brahmaroutu
Copy link
Contributor

…ectly

fixes: #46

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from wlan0 and xing-yang April 10, 2021 04:00
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2021
@brahmaroutu
Copy link
Contributor Author

@wlan0 Please review

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brahmaroutu, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlan0
Copy link
Contributor

wlan0 commented Apr 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit c784ac4 into kubernetes-retired:master Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bucket Request Create should check for BucketRequest.Spec.BucketInstanceName field instead of fetching the Bucket itself.

3 participants