Update to Go 1.20 and latest KRTE for e2e tests

[adrianludwin]

E2Es broke a few days ago, likely when test-infra upgraded to 1.20. I
also couldn't run staticcheck on my Google workstation, which has 1.20,
with the same failure message. Upgrading staticcheck fixed the problem;
I also took the opportunity to match the test-infra krte image as well
as the Golang version (which caused some minor reformatting), and also
made the integ tests hermetic by including the setup-envtest tool (bug
#252, based on an approach suggested in #253).

Tested: couldn't build on my workstation on Go 1.20 before this change;
can after it. Can also run integ tests after deleting local output of
setup-envtest.

Fixes #252

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianludwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adrianludwin]

/assign @rjbez17

[adrianludwin]

Filed kubernetes/test-infra#28722 to fix presubmit

[mochizuki875]

@adrianludwin
Thank you for your suggestion for #253 !
I tried to run test using your repo as below.(Please let me know if there is anything wrong)
However, make test still fails by same error...

$ git clone https://github.com/adrianludwin/hierarchical-namespaces.git -b krte 
$ go mod vendor
$ make test 
Go version (for logging posterity):
go version go1.20 linux/amd64
...
[BeforeSuite] [FAILED] [10.013 seconds]
[BeforeSuite] 
/home/ubuntu-user/go/hnc-test/hierarchical-namespaces/internal/anchor/reconciler_test.go:20

  Begin Captured GinkgoWriter Output >>
    STEP: configuring test environment 02/13/23 15:06:33.363
    STEP: starting test environment 02/13/23 15:06:33.363
    1.6762684033640285e+09	DEBUG	controller-runtime.test-env	starting control plane
    1.676268403373787e+09	ERROR	controller-runtime.test-env	unable to start the controlplane	{"tries": 0, "error": "fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"}
    sigs.k8s.io/controller-runtime/pkg/envtest.(*Environment).startControlPlane
    	/home/ubuntu-user/go/hnc-test/hierarchical-namespaces/vendor/sigs.k8s.io/controller-runtime/pkg/envtest/server.go:330
    sigs.k8s.io/controller-runtime/pkg/envtest.(*Environment).Start
    	/home/ubuntu-user/go/hnc-test/hierarchical-namespaces/vendor/sigs.k8s.io/controller-runtime/pkg/envtest/server.go:260
    sigs.k8s.io/hierarchical-namespaces/internal/integtest.HNCBeforeSuite
    	/home/ubuntu-user/go/hnc-test/hierarchical-namespaces/internal/integtest/setup.go:82
    github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func2
    	/home/ubuntu-user/go/hnc-test/hierarchical-namespaces/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:605
    1.6762684033746772e+09	ERROR	controller-runtime.test-env	unable to start the controlplane	{"tries": 1, "error": "fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"}
    ...

[rjbez17]

/lgtm

[adrianludwin]

/retest

Now that kubernetes/test-infra#28722 is fixed

[adrianludwin]

/retest

[adrianludwin]

cc @rjbez17 can you please re-approve this? I forgot to push my latest changes :P

cc @mochizuki875 sorry about that, please try again, it should be fixed now

[rjbez17]

/lgtm

[mochizuki875]

@adrianludwin
I tried again and confirmed it was fixed.
Thank you for your work!

[adrianludwin]

Great, thanks!

…

On Wed, Feb 15, 2023 at 8:52 AM Keita Mochizuki ***@***.***> wrote: @adrianludwin <https://github.com/adrianludwin> I tried again and confirmed it was fixed. Thank you for your work! — Reply to this email directly, view it on GitHub <#257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE43PZCLGCC5J6M5PSGSH2LWXTNRXANCNFSM6AAAAAAUYEF2NA> . You are receiving this because you were mentioned.Message ID: ***@***.***>