-
Notifications
You must be signed in to change notification settings - Fork 119
Remove useless lines related to unit test #260
Remove useless lines related to unit test #260
Conversation
|
Hi @mochizuki875. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @adrianludwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
|
Thanks! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, erikgb, mochizuki875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?:
/kind documentation
What this PR does / why we need it:
These lines are no longer be useful.
So I removed them.
https://github.com/mochizuki875/hierarchical-namespaces/blob/e19ea98273415002c310e9254f7610aec7d62779/docs/contributing.md?plain=1#L56-L58
cf.
#253 (comment)
https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/257/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L103-L108