-
Notifications
You must be signed in to change notification settings - Fork 118
docs: apply k8s style guide to HRQ quickstart example #316
docs: apply k8s style guide to HRQ quickstart example #316
Conversation
Hi @agilgur5. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adrianludwin could you review this docs PR as well? |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agilgur5, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like there are some merge conflicts. When you have a few, mind fixing them up and we can get this merged in. Thanks! |
- consistently use [present tense](https://kubernetes.io/docs/contribute/style/style-guide/#use-present-tense) and [active voice](https://kubernetes.io/docs/contribute/style/style-guide/#use-active-voice) - consistently [address the reader as "you"](https://kubernetes.io/docs/contribute/style/style-guide/#address-the-reader-as-you) Signed-off-by: Anton Gilgur <[email protected]>
ed5e226
to
20400c5
Compare
@rjbez17 rebased and fixed all merge conflicts; needs a new LGTM now |
Thanks for this change! /lgtm |
Summary
Apply more of k8s style guide to HRQ quickstart example
Details