🌱 Move compute and create ms to rollout planner #12841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
This was referenced Oct 9, 2025
Closed
fabriziopandini
force-pushed
the
move-compute-and-create-MS-to-rollout-planner
branch
from
a651610 to
9e88529
Compare
fabriziopandini
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
/test pull-cluster-api-e2e-main |
1 similar comment
Member
Author
|
/test pull-cluster-api-e2e-main |
sbueringer
reviewed
Oct 13, 2025
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_controller.go
Outdated
Show resolved
Hide resolved
fabriziopandini
added
the
tide/merge-method-squash
Member
Author
|
/test pull-cluster-api-e2e-main |
Member
|
/test pull-cluster-api-e2e-main For more data, but needs some fixes: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/12841/pull-cluster-api-e2e-main/1977759888578711552 |
Member
Author
|
/test pull-cluster-api-e2e-main |
fabriziopandini
force-pushed
the
move-compute-and-create-MS-to-rollout-planner
branch
from
125b80e to
38f819a
Compare
Member
Author
|
/test pull-cluster-api-e2e-main |
sbueringer
reviewed
Oct 14, 2025
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
Member
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: e0e506614c711c49460fa61d30f541393310511c
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
deleted the
move-compute-and-create-MS-to-rollout-planner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR completes the introduction of the rollout planner in the MD controller, paving the ground for adding the logic for in-place upgrades in a follow up PR
Notably with this PR
Which issue(s) this PR fixes:
Part of #12291
Fix case 3 in #10753
/area machinedeployment