-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Add in-place to rollout planner #12865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add in-place to rollout planner #12865
Conversation
|
/test pull-cluster-api-e2e-main |
alexander-demicev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for taking care of this
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
|
/test pull-cluster-api-e2e-main |
internal/controllers/machinedeployment/machinedeployment_controller.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
...llout, 12 replicas, maxsurge 3, maxunavailable 1, scale down to 6, random(0).test.log.golden
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_planner_test.go
Outdated
Show resolved
Hide resolved
|
Great work, thank you! /lgtm |
|
LGTM label has been added. Git tree hash: 23d69c986166e5b6b5874ee59dd6649ad338a0a9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the logic to handle in-place updates when performing machine deployment rollouts.
Please note that:
Which issue(s) this PR fixes:
Part of #12291
/area machinedeployment