✨ KCP: implement trigger in-place update #12897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
added
the
area/provider/control-plane-kubeadm
79 tasks
sbueringer
force-pushed
the
pr-kcp-trigger-in-place
branch
from
07b1d8f to
68408cd
Compare
Member
Author
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-kcp-trigger-in-place
branch
4 times, most recently
from
a9146fd to
8d46ae0
Compare
17 tasks
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-kcp-trigger-in-place
branch
from
8d46ae0 to
ea9da88
Compare
k8s-ci-robot
added
size/XL
Member
Author
|
/test pull-cluster-api-e2e-main |
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
furkatgofurov7
left a comment
furkatgofurov7
left a comment
There was a problem hiding this comment.
Mostly suggestions for code improvement, great work otherwise!
controlplane/kubeadm/internal/controllers/inplace_canupdatemachine_test.go
Show resolved
Hide resolved
sbueringer
commented
Oct 27, 2025
controlplane/kubeadm/internal/controllers/inplace_canupdatemachine_test.go
Show resolved
Hide resolved
Member
fabriziopandini
left a comment
fabriziopandini
left a comment
There was a problem hiding this comment.
Nice, great work in transition KCP from the original state to where we will be at the end of this PR!
sbueringer
added
the
tide/merge-method-squash
Member
Author
|
@fabriziopandini @furkatgofurov7 Thx for the reviews Findings should be all addressed now, PTAL :) /test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: cd310783a4e0b08e5ce2795ba6a291c81a6286de
|
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12291