Skip to content

🌱 Add in-place to machineset controller #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2025
Merged

🌱 Add in-place to machineset controller #12906

merged 4 commits into from
Nov 3, 2025

Conversation

@fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Oct 28, 2025 •
edited
Loading

What this PR does / why we need it:
This PR adds to the MS controller the code to

  • start a move operation when reconciling machines on an old MS
  • complete the move and trigger the in place update when reconciling machines the new MS

Which issue(s) this PR fixes
Part of #12291

/area machinedeployment

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 28, 2025
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Oct 28, 2025

/test pull-cluster-api-e2e-main

@sbueringer sbueringer mentioned this pull request Oct 29, 2025
Open
79 tasks
@fabriziopandini fabriziopandini force-pushed the add-in-place-to-machineset-controller branch from aebcdbd to 47836cc Compare October 29, 2025 14:04
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Oct 29, 2025

/test pull-cluster-api-e2e-main

@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Add in-place to machineset controller (oldMS) 🌱 Add in-place to machineset controller (oldMS) Oct 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2025
@fabriziopandini fabriziopandini force-pushed the add-in-place-to-machineset-controller branch from 47836cc to b7e8f19 Compare October 31, 2025 12:54
@fabriziopandini fabriziopandini changed the title 🌱 Add in-place to machineset controller (oldMS) 🌱 Add in-place to machineset controller Oct 31, 2025
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Oct 31, 2025

/test pull-cluster-api-e2e-main

sbueringer
sbueringer reviewed Nov 3, 2025
View reviewed changes
sbueringer and others added 2 commits November 3, 2025 15:35
@sbueringer
Fix review findings
28c47bf 
Signed-off-by: Stefan Büringer [email protected]
@fabriziopandini
Merge pull request #315 from sbueringer/pr-add-in-place-to-machineset…
aaff195 
…-controller-review

🌱 Fix review findings
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 3, 2025
@fabriziopandini fabriziopandini force-pushed the add-in-place-to-machineset-controller branch from 65965c6 to 11f2a15 Compare November 3, 2025 17:23
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Nov 3, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

LGTM label has been added.

Git tree hash: 7ae0ce80eb7a5f89c0d8b0e6a77fe96a3ab1594a

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

Unrelated flake

/override pull-cluster-api-e2e-main-gke

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main-gke

In response to this:

Unrelated flake

/override pull-cluster-api-e2e-main-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 6e15d77 into kubernetes-sigs:main Nov 3, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 3, 2025
@fabriziopandini fabriziopandini deleted the add-in-place-to-machineset-controller branch November 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@sivchari sivchari Awaiting requested review from sivchari

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@fabriziopandini @sbueringer @k8s-ci-robot