-
Notifications
You must be signed in to change notification settings - Fork 168
Add NodeStageVolume disk size validation before mounting #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hajiler The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1b7e25c to
8a3e720
Compare
8a3e720 to
aa1cf88
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@hajiler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The govet error must be a new check, as that setup_e2e_test code has been in since february. I'll force-submit, and push a PR to fix the e2e test. |
|
/cherry-pick release-1.21 |
|
@hajiler: #2178 failed to apply on top of branch "release-1.21": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…upstream-release-1.21 Automated cherry pick of #2178: Add NodeStageVolume disk size validation before mounting
What type of PR is this?
What this PR does / why we need it:
This PR introduces a safeguard to compare a disk's reported size against its expected size before running mkfs. If the disk's actual size does not match the expected size, the NodeStageVolume fails, and the operation will be retried.
Which issue(s) this PR fixes:
Fixes #
#2179
Special notes for your reviewer:
Does this PR introduce a user-facing change?: