Skip to content

[release-1.21] pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ regions #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

[release-1.21] pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ regions #2180

merged 2 commits into from
Oct 20, 2025
+8 −2

Conversation

@k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2117

/assign sunnylovestiramisu

NONE

JordanP and others added 2 commits September 25, 2025 00:01
@JordanP
pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ r…
571542b 
…egions

GCP now offers more than 10 regions in Europe. Update the regex accordingly.
@JordanP
Add unit test
23c22b0
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2025
@sunnylovestiramisu
Copy link
Contributor

/retest-required

1 similar comment
@sunnylovestiramisu
Copy link
Contributor

/retest-required

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025 •
edited
Loading

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm 23c22b0 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 23c22b0 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 23c22b0 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunnylovestiramisu
Copy link
Contributor

/retest-required

@sunnylovestiramisu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit c2010bf into kubernetes-sigs:release-1.21 Oct 20, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@hajiler hajiler Awaiting requested review from hajiler

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-infra-cherrypick-robot @sunnylovestiramisu @k8s-ci-robot @JordanP