add openapi/path field to use custom openapi schema document #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
natasha41575
force-pushed
the
UseCustomOpenApiSchema
branch
3 times, most recently
from
9f51292 to
2e2c91c
Compare
natasha41575
force-pushed
the
UseCustomOpenApiSchema
branch
from
2e2c91c to
7dd0ade
Compare
monopole
reviewed
Feb 22, 2021
natasha41575
force-pushed
the
UseCustomOpenApiSchema
branch
2 times, most recently
from
52b2e6f to
1338ce3
Compare
natasha41575
force-pushed
the
UseCustomOpenApiSchema
branch
from
1338ce3 to
5a0e193
Compare
monopole
reviewed
Feb 24, 2021
|
|
||
| func writeTestBase(th kusttest_test.Harness) { | ||
| th.WriteK("/app/base", ` | ||
| th.WriteK("/base", ` |
There was a problem hiding this comment.
Is there some reason here that these all have to be absolute paths?
It's preferable to omit the /, so readers don't copy this and think that kustomization directories aren't relocatable.
There was a problem hiding this comment.
ah sorry, I meant to edit this earlier and got distracted by something else. Thanks for merging; I can make a separate PR for this
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution for #2825
implements part of KEP: kubernetes/enhancements#2206
allow users to specify their own custom openapi schema files to use with kustomize, to support strategic merge patching with CRDs
ALLOW_MODULE_SPAN