Update the loadwatcher library to the latest release for trimaran plugins #341

wangchen615 · 2022-02-18T01:41:43Z

The PR updated the loadwatcher library to v0.2.2, which will fix the invalid self-signed SSL connection errors for Prometheus queries in certain environments, such as AWS, GCP, etc., as they disable insecure_skip_verify for all HTTPS requests.

Besides, it updates the invalid manifests/trimaran/scheduler-config.yaml with example pluginConfig.

@zorro786 @sci110680

/assign @Huang-Wei

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes and closes #266.

Special notes for your reviewer:

k8s-ci-robot · 2022-02-18T01:41:51Z

Hi @wangchen615. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Huang-Wei · 2022-02-18T01:49:34Z

/ok-to-test

zorro786 · 2022-02-18T02:26:23Z

pkg/trimaran/loadvariationriskbalancing/collector.go

 	} else {
+		insureSkipVerify := true
+		if args.MetricProvider.InsecureSkipVerify != "" {
+            insureSkipVerify = strings.ToLower(args.MetricProvider.InsecureSkipVerify) == "true"


insecureSkipVerify

Thanks for spotting this.

wangchen615 · 2022-02-18T03:03:35Z

/test pull-scheduler-plugins-unit-test-master

pkg/apis/config/types.go

pkg/trimaran/loadvariationriskbalancing/collector.go

Huang-Wei · 2022-02-24T22:19:24Z

@wangchen615 the changeset looks weird. Could you rebase and ensure there is no commit like "Merge..."?

wangchen615 · 2022-02-24T22:22:32Z

@wangchen615 the changeset looks weird. Could you rebase and ensure there is no commit like "Merge..."?

@Huang-Wei yes. Sorry, I was just pulling updates for a test and mistakenly did a merge. Will do a rebase and re-add my changes.

…gins

wangchen615 · 2022-02-28T15:04:31Z

@Huang-Wei and @zorro786 Now there is only one commit with necessary API changes in both types.go and defaults.go. Please help take another look.

pkg/apis/config/types.go

Huang-Wei

@wangchen615 could you run hack/update-codegen.sh to ensure the conversion logic is covered. I'd expect some changes in the conversion codegen.

wangchen615 · 2022-03-03T14:58:25Z

@wangchen615 could you run hack/update-codegen.sh to ensure the conversion logic is covered. I'd expect some changes in the conversion codegen.

Hi, @Huang-Wei , as the generated code will remove some other plugins' code, I manually added back changes related to my code.

…vider args with insecureSkipVerify field

Huang-Wei · 2022-03-04T19:42:55Z

pkg/apis/config/scheme/scheme_test.go

      metricProvider:
        type: Prometheus
        address: http://prometheus-k8s.monitoring.svc.cluster.local:9090
+        insecureSkipVerify: false


Can you remove this and verify if it's defaulted to true?

@Huang-Wei , we tested the default behavior in #L81 and #L132

I see. Thanks.

Huang-Wei · 2022-03-04T22:09:26Z

/lgtm
/approve

k8s-ci-robot · 2022-03-04T22:09:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot assigned Huang-Wei Feb 18, 2022

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2022

k8s-ci-robot requested review from cwdsuzhou and seanmalloy February 18, 2022 01:41

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2022

zorro786 reviewed Feb 18, 2022

View reviewed changes

wangchen615 force-pushed the master branch 3 times, most recently from 979d000 to a844ceb Compare February 18, 2022 02:54

zorro786 reviewed Feb 18, 2022

View reviewed changes

pkg/apis/config/types.go Outdated Show resolved Hide resolved

zorro786 reviewed Feb 18, 2022

View reviewed changes

pkg/trimaran/loadvariationriskbalancing/collector.go Outdated Show resolved Hide resolved

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2022

wangchen615 force-pushed the master branch from e588a49 to 3b0f91d Compare February 26, 2022 02:16

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2022

wangchen615 force-pushed the master branch from 3b0f91d to 360fbf9 Compare February 26, 2022 05:08

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2022

Update the loadwatcher library to the latest release for trimaran plu…

5bed368

…gins

wangchen615 force-pushed the master branch from 360fbf9 to 5bed368 Compare February 26, 2022 06:11

Huang-Wei reviewed Mar 1, 2022

View reviewed changes

pkg/apis/config/types.go Show resolved Hide resolved

Huang-Wei reviewed Mar 1, 2022

View reviewed changes

manually added back the generated code changes

ea5c001

Added UT for InsecureSkipVerify field in MetricProvider

fe3e07e

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2022

Added targetLoadPackingConfigWithPrometheusArgsFile to test metricPro…

4a78c35

…vider args with insecureSkipVerify field

Huang-Wei reviewed Mar 4, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022

k8s-ci-robot merged commit 4cbdc59 into kubernetes-sigs:master Mar 4, 2022

wangchen615 mentioned this pull request Mar 9, 2022

Enable OpenShift Authentication for scheduler plugins openshift/secondary-scheduler-operator#30

Merged

wangchen615 mentioned this pull request Aug 16, 2022

REQUEST: New membership for wangchen615 kubernetes/org#3616

Closed

9 tasks

Uh oh!

Update the loadwatcher library to the latest release for trimaran plugins #341

Update the loadwatcher library to the latest release for trimaran plugins #341

Uh oh!

Conversation

wangchen615 commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Uh oh!

k8s-ci-robot commented Feb 18, 2022

Uh oh!

Huang-Wei commented Feb 18, 2022

Uh oh!

zorro786 Feb 18, 2022

Choose a reason for hiding this comment

Uh oh!

wangchen615 Feb 18, 2022

Choose a reason for hiding this comment

Uh oh!

wangchen615 commented Feb 18, 2022

Uh oh!

Uh oh!

Uh oh!

Huang-Wei commented Feb 24, 2022

Uh oh!

wangchen615 commented Feb 24, 2022

Uh oh!

wangchen615 commented Feb 28, 2022

Uh oh!

Uh oh!

Huang-Wei left a comment

Choose a reason for hiding this comment

Uh oh!

wangchen615 commented Mar 3, 2022

Uh oh!

Huang-Wei Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

wangchen615 Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

Huang-Wei Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

Huang-Wei commented Mar 4, 2022

Uh oh!

k8s-ci-robot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangchen615 commented Feb 18, 2022 •

edited

Loading